Patching Vivaldi with batch scripts

oudstand

@luetage said in Patching Vivaldi with batch scripts:

That’s the mistake, the script tags have to go into the body tag, as described in the first post.

Oh my bad
I've updated my previous code. It now adds the script before </body>

Wasn't it in the previous version also in the HEAD?

stardepp

@luetage This is how I have implemented it now:

Bild Text

But this error still occurs:

Bild Text

What did I do wrong?

stardepp

@luetage i found out myself:

<!-- Vivaldi window document -->
<!DOCTYPE html>
<html>
<head>
  <!-- Keep the styling in sync with ./browser.html -->
  <meta charset="UTF-8" />
  <title>Vivaldi</title>
  <link rel="stylesheet" href="style/common.css" />
  <link rel="stylesheet" href="chrome://vivaldi-data/css-mods/css" />
</head>

<body>
</body>
 <script src="custom.js"></script>
</html>

I am very happy about that.

Bild Text

Pathduck

@stardepp As custom mods are not "offically supported" by Vivaldi, I have moved your posts here, hope that's OK

stardepp

@Pathduck said in Patching Vivaldi with batch scripts:

@stardepp As custom mods are not "offically supported" by Vivaldi, I have moved your posts here, hope that's OK

Yes, you got that so right.

shifte

@stardepp
Good job!

barbudo2005

@stardepp

I don't see the difference. Please clarify.

This is my window.html file:

<!-- Vivaldi window document -->
<!DOCTYPE html>
<html>
<head>
  <!-- Keep the styling in sync with ./browser.html -->
  <meta charset="UTF-8" />
  <title>Vivaldi</title>
  <link rel="stylesheet" href="style/common.css" />
  <link rel="stylesheet" href="chrome://vivaldi-data/css-mods/css" />
</head>

<body>
</body>
<script src="custom.js"></script>
</html>

Is it Ok?

stardepp

@barbudo2005 Just copy my code and use it.

Pathduck

@stardepp The script element is not allowed inside the html element. It needs to go inside the body element. What you're doing is not valid HTML code.

It might work (browsers do some "fool proofing", but is not the correct way to add scripts

barbudo2005

@Pathduck

So mine is Ok?

Pathduck

@barbudo2005 No, yours is the exact same code

oudstand

@barbudo2005 your file has to look like this:


<!-- Vivaldi window document -->
<!DOCTYPE html>
<html>
  <head>
    <!-- Keep the styling in sync with ./browser.html -->
    <meta charset="UTF-8" />
    <title>Vivaldi</title>
    <link rel="stylesheet" href="style/common.css" />
    <link rel="stylesheet" href="chrome://vivaldi-data/css-mods/css" />
  </head>
  <body></body>
  <script src="custom.js"></script>
</html>

stardepp

@Pathduck But for me all JavaScript modifications work like this with this code.

Pathduck

@oudstand said in Patching Vivaldi with batch scripts:

<body></body>
<script src="custom.js"></script>
</html>

Does it really work? Placing your <script> element like that is not valid HTML - it should go inside the body as stated in the guide.

https://forum.vivaldi.net/topic/10549/modding-vivaldi#:~:text=inside the body element

But if it works, I guess it's fine ...

luetage

@barbudo2005 It’s not. Your script is below the body closing tag </body>

barbudo2005

@luetage @Pathduck @oudstand

So you have to delete that line from browser.html?

Please post the detail of browser.html, since I overwrote the new one as I always do.

luetage

<body><script src="test.js"></script></body>

You should look into HTML basics. Will only take you 20 minutes, it is useful to know a little about it.

barbudo2005

@luetage

Don't be a bad person, give me the whole bar of chocolate, not just a square. LOL.

Please post the complete file detail.

Pathduck

@barbudo2005

barbudo2005

@Pathduck @luetage

You really are bad persons. LOL

That's fine for the long term, but not when you're starving.