AutoSave Sessions Mod

[code3]

@boroda74 It would be better to merge your changes with LonM:
Create a GitHub account
Go to https://github.com/LonMcGregor/VivaldiMods

Find the file to change, eg
https://github.com/LonMcGregor/VivaldiMods/blob/master/mods/advancedPanels.js

Click the three dots then “edit this file”

Make a pull request

Note that this isn’t the ideal way to do Git but is easy if you’re only editing one or two files and don’t know much about git.

[boroda74]

@code3

Actually it was my initial idea not to create new entities if it's possible, but I haven't thought about creating pull request on git. I'll do this, but I'm afraid my request will be rejected. Though I was trying to leave all original code as is as much as possible, and core functionality of my version of mod is the same (except for applying settings changes in real-time and correct rescheduling if autosave period has been changed), the code itself doesn't look as just a small modification of original code. It's easier to completely replace original code by mine than edit original code according to my modification of mod.

[luetage]

@boroda74 Nobody is gonna download some random zip file. You have done nothing to actually show your changes. Providing directly accessible code either here on the forum, or in one of the many git repository hosting services is crucial. And while you are allowed to take someone else’s project, change it and go with it (depending on license), of course it’s better when everyone works together. Should your changes be useful, I’m sure @Lonm will consider them.

[boroda74]

@luetage said in AutoSave Sessions Mod:

@boroda74 Nobody is gonna download some random zip file.

I'm not familiar with forum habits/conventions. I've replaced here links to .zip files by links to mods code on GitHub. Thought personally I don't understand why displaying (large!) code on the screen (note that without the ability to quickly select all code, and only code) is much better than providing a link to .zip file with exactly the same plain text files. Just to make more difficulties for users to create local text files? But if forum members think that it's better, well, no problem.

You have done nothing to actually show your changes.

I'm not sure how I must show my changes (though many parts of original code are preserved in new code, the structure of these parts and parts of new code is completely different. Parts of original code are moved to new locations in my variant of mod). Also, I don't understand who will read what is now changed in code (maybe except for LonM, in case if he is willing to merge my code and his one). Changes in functionality I've described for regular users.

And while you are allowed to take someone else’s project, change it and go with it (depending on license), of course it’s better when everyone works together. Should your changes be useful, I’m sure @Lonm will consider them.

As I said:

I'll do this, but I'm afraid my request will be rejected.

I also think that it will be better to merge 2 mods, which do the same work from the view of end user, just in slightly different ways.

[LonM]

I guess I should weigh in on this - the only way I can merge anything is if its on some kind of public git - it doesn't have to be github (but github is the easiest, as the code is already there so I can do pull requests). I could pull from gitlab, atlassian or others.

I could probably merge the translation easy enough. For the rest of the code I'd have to have a proper look at it.

I don't think that code has to be merged. Its fine for people to fork my mods and make them their own. Particularly as I haven't really been doing much to update them lately.

[code3]

@lonm said in AutoSave Sessions Mod:

Particularly as I haven't really been doing much to update them lately.

That might be the reason to merge changes from others.

When I wrote this I didn’t realize that @boroda74 had made changes to the file structure. But I still think merging changes could be good, especially since this mod has gotten so popular many people will download it, few people will download a fork.

[code3]

@boroda74 If you do not want to merge into LonM’s repo you could provide the ZIP on the releases page.

[boroda74]

@lonm said in AutoSave Sessions Mod:

I guess I should weigh in on this - the only way I can merge anything is if its on some kind of public git - it doesn't have to be github (but github is the easiest, as the code is already there so I can do pull requests). I could pull from gitlab, atlassian or others.

I've published my 2 mods (variants of your Autosave Sessions and Advanced Panels mods) on GitHub yesterday:
https://github.com/boroda74/Vivaldi-Mods

I could probably merge the translation easy enough. For the rest of the code I'd have to have a proper look at it.

My Autosave Session leaves much of your code untouched, but unfortunately it's very hard to determine what exactly has been changed. Only if to read all modified code. But I'll be very happy if you've decided to merge these 2 mods.

It's mush easier to merge my Session Panels mod with your Advanced Panels mod (there are very little changes in my mod), but your mod is more an example/template for creating custom web panels mods, and my Sessions Panel is not intended to be a template. So I'm not sure if it's worth to merger them despite that it's very easy.

[boroda74]

@code3 said in AutoSave Sessions Mod:

@boroda74 If you do not want to merge into LonM’s repo you could provide the ZIP on the releases page.

I've added direct links to GitHub along with download links to .zip files (also, I've moved .zip files from Google Drive to mediafire.com).

[boroda74]

@LonM

I've updated both my mods:

• UI/UX improvements and some bug fixes
• Now changing localization of both mods can be made in UI (without changing constants in source code). All changes (including localization changes) are applied immediately (browser restart is not required).
• Now it's possible to overwrite existing session, but private sessions can be overwritten only from private Vivaldi window, and not private sessions can be overwritten only from not private Vivaldi window (it's artificial limitation to avoid accidental mistakes).

My Autosave Sessions variant:

https://github.com/boroda74/Vivaldi-Mods/blob/main/Mods/autosave-sessions.js

My Session Manager variant:

https://github.com/boroda74/Vivaldi-Mods/blob/main/Mods/sessions-panel.js

https://github.com/boroda74/Vivaldi-Mods/blob/main/Mods/sessions-panel.css

@LonM

I could make a pull request to your gits, if you are willing to merge our mods. Also, I've tried to preserve the versatility of your Advanced Panels mod in my Session Manager mod.

[LonM]

@boroda74 I've already made a merge request here: https://github.com/LonMcGregor/VivaldiMods/pull/30

I've been quite busy recently, so not able to review it yet. There are a lot of changes to look through first.

I'll add your latest changes to that merge request when I get a chance.

[boroda74]

@lonm
I've slightly improved UI and code readability. Functionality is not changed. Git links are the same as in prev. post.

[yaha12]

@lonm Circa January 26, 2022 this mod stopped working for me. The Advanced Panels mod stopped working as well. I commented on that thread also.

[guigirl]

@yaha12 Oh goody, a cross-post.

https://forum.vivaldi.net/post/556234

[yaha12]

@guigirl I was able to get this mod working by going through all of the installation steps anew. Still no luck on the other mod though.

[BeerLion]

Both session mods (autosave and panel) stopped working recently. Seems like api was changed since 5.8.2936.3(?) - no more saveOpenTabs function in vivaldi.sessionsPrivate. Maybe because of new Workspaces experiment, which has it's own Sessions panel....

[LonM]

@BeerLion Yes. It is currently broken, and the latest changes by vivaldi have not yet been published into the source code which I ideally would have to be able to update the mod.

[stardepp]

Since the update to Vivaldi 6.0, Auto Save Sessions no longer works.

Maybe it has something to do with here:

https://forum.vivaldi.net/topic/85717/new-experimental-feature-discovered-session-panel

[LonM]

@stardepp Yes, you've discovered it. As Vivaldi are working on this feature, there is no need for me to continue working on this mod, or the session panel mod.

[stardepp]

@LonM Nevertheless, I am very grateful to you about your modification Autosave Sessions Mod. Has always worked very reliably.