Bookmark Bar only on Speed Dial (like chrome)

[luetage]

@dpn No, it should be an error that shows your custom modification file. Did you inspect the User Interface? Read here ☛ https://forum.vivaldi.net/topic/16684/inspecting-the-vivaldi-ui-with-devtools

[dpn]

@luetage

[dpn]

@dpn I saved the script that @nomadic posted as bbntp.js

[dpn]

@dpn

Error in event handler: TypeError: Error in invocation of tabs.get(integer tabId, function callback): No matching signature.
    at change_display (<URL>) browser.html:1 

Error in event handler: TypeError: Error in invocation of tabs.get(integer tabId, function callback): No matching signature.
    at change_display (chrome-extension://mpognobbkildjkofajifpdfhcoklimli/bbntp.js:11:19)

Is this it ?

Any ideas how to resolve this ?

[nomadic]

@dpn I updated the code in my previous post.

It was an issue with the different listeners being used to detect tab changes not all returning the same event data. Some return just the tab ID while others return the entire tab object.

That is why you are seeing that No matching signature error, because the function is expecting an integer tab ID in the first parameter, but the way I had it coded, that was sometimes being input as undefined (which is not a valid integer tab ID).

---

And sorry, it took me a bit to get back to this, been busy.

[dpn]

@nomadic Thank you, .

[nomadic]

@dpn No problem, happy to help

It seemed like a good idea for a mod, so I might even use it myself. One of the main reasons I actually started using Vivaldi was that I wanted a more compact browser interface. Having the bookmark bar only visible when necessary might help with that.

Opera vs my modded Vivaldi

---

@dpn said:

Thank you, .

And also...wow...thanks! I think that makes this my first ever paid gig for for programming! Makes all the gray hairs I gained from squeezing computer science classes into my course schedule worth it.

And luckily, I now also have almost a solid year to figure out where to report that on my taxes

Thanks again!

[TheLich132]

Hi, very nice script! Sadly it breaks for me after playing video at fullscreen, e.g. in youtube

Is this fixable?

[nomadic]

@thelich132 Yes, that should be fixable. I will try to get to it later tonight or tomorrow. It probably just requires adding a mutation observer that I have already written before.

[dpn]

The update to 4.0 has broke the script.
Bookmark Bar is visible all the time.

[dpn]

@dpn

[nomadic]

@TheLich132 and @dpn I updated the code in the original post.

Let me know if it works for you, and thanks for letting me know it was broken

[TheLich132]

@nomadic Thank you very much for updating and fixing script! After quick testing everything works perfectly. Will let you know if something breaks after long run.

[dpn]

@nomadic Thank you.

What I didn't realize until today, was that on each update including minor updates like the one we got today, is that, the browser.html has to be re-edited to include the script source, and the script re-added to the Framework Resources folder.

[hlehyaric]

@dpn That's the drawback of JS mods. Unlike CSS mods, they are overridden after each update & so you have to re-install them.

[dpn]

Error handling response: TypeError: Cannot read property 'url' of undefined
    at <URL>
browser.html:1
Error handling response: TypeError: Cannot read property 'url' of undefined
    at chrome-extension://mpognobbkildjkofajifpdfhcoklimli/bbntp.js:12:27

[dude99]

CSS version is over here: https://forum.vivaldi.net/post/587853

[vitormathews]

Doesn't work anymore.

[nomadic]

@vitormathews Know it is a bit buried in the replies, but did you try my modified version?

https://forum.vivaldi.net/post/480435

It seems to still work from a quick test.

[vitormathews]

@nomadic Here it didn't work at all.