Tree Tabs

kroppy

@pina_coladas said in Tree Tabs:

@kroppy lol sorry for the wild demands.
I'd like to report that on the latest version tabs are sometimes shuffled out of order. I think this only happens when I close and restore vivaldi but I'm not sure.
And when I drag and drop a URL onto the sidebar it loads the page in the tree tabs sidebar instead of loading normally with a new tab placed in the sidebar. I think I remember this working right in previous versions.

Drag&Drop does not load a page here. What is your Vivaldi version? But it does not load new tab either, I have to make it do so.
As for shuffled tabs, yes it can happen, but only after restart. After dragging tabs around wait around 5 seconds before closing/restarting Vivaldi, otherwise some data might not get saved. I have a small fix for this, since in Firefox it was even slower. But I will not release it till somewhere next week, since I'm not at home.
Sorry about that
EDIT: by dragging tabs around I mean both, in sidepanel or in Vivaldi's TabBar. Each iteration of either requires 2 seconds to get to queue. Then it's saved in a millisecond. Moreover, once a minute there is an ulterior check if tabs were saved ok.

kroppy

@luetage said in Tree Tabs:

@kroppy Yeah, makes sense, but it's still nicer operating it packed instead of loading it unpacked. How about putting it on github so that we can just pull it with command line, instead of downloading it from google drive?

Because I hate git? I use svn... Oh well, when I will have time I will put it there. But expect to some branches to appear from nowhere since I don't have much experience with git.

luetage

@kroppy lol
Then simply don't use git, it's not that important. On another note, the problem is not many people will find this thread on Vivaldi and most Vivaldi users won't go looking for extensions on the Opera add-ons site. But it seems your user base will be coming from Opera and Firefox. I noticed your original vertical tabs extension on opera too just now.

kroppy

@GHM113
He does nothing with Ctrl+tab.
All he does is move tabs along with his sidepanel's tabs when you drag them around. They move in syncro. In this way using Ctrl+Tab, tabs are switched in the same order that is present on top's tab bar and his panel. Sure, I can move tabs at the top as he does here, as I do in my original "Vertical tabs" extension for Opera where ctrl+tab works just like it should.... But how am I supposed to arrange them with trees?

Let me explain the problem with a little example:
This could be a tree structure inside of the sidepanel:
a[ b[ c[1,2,3], 4,5,6,7 ], d[8,9] ], 10
Lets say letters are collapsed (closed) parent tabs and numbers are children tabs inside of trees.

And lets say I sorted them in the same way on top:
a,b,c,1,2,3,4,5,6,7,d,8,9,10

Let me confuse you a little more, but bare with me
Now supposedly your active tab is a, when you press Ctrl+Tab, what would happen? You would end up in b instead of 10. Same goes on, if your active tab is b, you will end up in c, instead of d. This order would work only inside of a tree without any parents. If your active tab would be 1,2,4,5,6 or 8, Ctrl+tab would switch to the next correct tab which is on the same level.

So as you can see, could it help? Sure, but only partially. When inside of a tree? Absolutely. But with any collapsed tree in between, nope, you would jump straight inside another tree.

As things stand now, WebExtensions, can add own shortcuts, but can't replace original ones. Ctrl+Tab and Ctrl+Shift+Tab are Vivaldi/Opera/Firefox standard shortcuts, that cannot be replaced with Web extensions API. Probably for security reasons. I tried it already. Vivaldi at least lets you change shortcuts, so when Ctrl+Tab is freed I can "re assign" it with my own implementation of tabs switching. But to add even more salt to injury, Firefox don't have shortcut options... And before you mention TST, it has its own Ctrl+tab, since it uses old more flexible API, which is being ditched as we speak, which makes me angry as I was long time user before switching to Opera. Depressing isn't it?

So in essence I can add a new shortcut, to switch tabs, but not Ctrl+tab. If you are okay with another combination I'm all ears

kroppy

@GHM113 said in Tree Tabs:

There is a bug on bugzilla about better keyboard shortcut support for WebExtensions, I left a comment there and tried to describe this problem

For now as things work this way and we don't have permissions to replace original keys. And as I explained before, sorting tabs in tabstrip will not help much as browser will switch tabs in order at the top instead of the trees depth and order...

In next release which is almost ready to be published I made Alt+1 and Alt+2 shortcuts for next and previous tabs. Hope that it will be comfortable enough and will help. In Opera and Vivaldi you can change that manually afterwards to Ctrl+Tab/Ctrl+Shift+Tab in options under keyboard shortcuts, when you scroll down to Tree Tabs keys, although I don't recommend it.

kroppy

@GHM113 Nice

luetage

Thought I'd share a theme here. Tried to appropriate it for Vivaldi's subtle/light themes (and my own highlight color).

legacy_theme

Hadden89

Cool, I'm testing and it works nicely
It only miss an "audio icon" (probably not implemented yet).
On latest stable, I see a glitch in the panel (due dark theme?)
Other web panels are fine.

kroppy

@Hadden89 Ok, should be fixed now.

Hadden89

@kroppy said in Tree Tabs:

@Hadden89 Ok, should be fixed now.

Thanks.
Nice update, the glitch is gone and the audio icon is present.
About that, consider making it clickable (mute/unmute status) and allow to move on the right - so it doesn't overlap tab favicon on left - and add an option to always hide "close button" as I use only middle click for that. Great work.

kroppy

@Hadden89 said in Tree Tabs:

@kroppy said in Tree Tabs:

@Hadden89 Ok, should be fixed now.

Thanks.
Nice update, the glitch is gone and the audio icon is present.
About that, consider making it clickable (mute/unmute status) and allow to move on the right - so it doesn't overlap tab favicon on left - and add an option to always hide "close button" as I use only middle click for that. Great work.

@Hadden89 Audio icons were always there. It's Vivaldi's internal bug that it does not refresh correctly. I just made my own checker for media icons for Vivaldi. I will upload version 0.0.12 in few hours so wait for that. And by the way, media icons are clickable, it just does not give the visual input that you can click on them!
As for options, if time allows me, I will implement that. I will have to ask folks to translate options page for me as well. Hopefully they won't get mad

kroppy

Sorry for delay. Update 0.0.12 is now up. Media icons should now refresh.

kroppy

@luetage Cool Can I add that to my google drive? I will name theme correctly by your nickname if you want.

luetage

@kroppy Sure, upload it. And no, call it whatever you want, my name serves no purpose under these circumstances.

kroppy

@luetage said in Tree Tabs:

@kroppy Sure, upload it. And no, call it whatever you want, my name serves no purpose under these circumstances.

Why not? Anyone deserves some credit for their work. That`s what I think.
Anyway I will reset the toolbar for it, so anyone will be able to start from default and put their own.

luetage

I just noticed you have the names of the others in the download section too. Well, I don't mind either way, do as you please. I just fixed one more thing that bugged me in the theme, so I updated it just now.

kroppy

@luetage Ok. Same link?

luetage

Yep, same link.

kroppy

@jimbo1qaz Yes. I don't sycro them, I save my own tabs order and since tabs are ordered in trees, there is no direct correlation with flat array of tabs on top. The other reason is to avoid compatibility issues with other extensions, like "New tabs at end", "Sort tabs", "Tabs open relative" and similar. All mentioned would mess up your trees. Slowly I will be implementing sorting, closing trees, maybe some saving trees for later and so on. And who knows... groups. All depends how much time I will have this summer.

Njol

Finally a useful tree tabs extension, and I can even style it black/orange like my Vivaldi

For now, I have just one inconvenience to report: The buttons to open/collapse a group are pretty small and thus difficult to click on. I made my own custom CSS file to make them larger (from 6x6px to 10x10px), which makes them much easier to click on. Instead of increasing the actual size of the buttons, one could also only increase the size of the clickable area, which could also be made to fill the whole available space around the button.

Also, for some reason tabs' titles are not vertically centered for me (using the largest tab size available in the options) and changing a tab's vertical-align doesn't seem to help (maybe because the tab title is higher than the tab itself). Adding a margin-top of -1.5px helped center the titles for me, but is a very hacky solution.

I also have suggestions for two new options that I would like to see (and already hacked together for myself) which might or might not be useful for others: a different hover color for the toolbar icons (e.g. using .button:hover:not(.on) .button_img {background-color: var(--button_hover_icons, #808080);}), and an option to disable close buttons altogether (I always close my tabs with the middle mouse button or ctrl+W, making the close button redundant and potentially harmful when misclicking).

PS: here's a screenshot of how it looks with my settings & changes (the pin button is hovered and thus orange):