Open in Dialog mod
-
@oudstand While using it today, I noticed an odd bug. When using the Ctrl+Alt+Middle mouse click to open in dialog, it was opening two dialogs of the same url.
After a bit of debugging, I think I have a fix for you to test/include.
on your 'setUrlClickObserver', when adding the mousedown event listener, on the first if statement I added a 'return' so that it would not trigger the "show dialog" a second time
something like this snippet :
// Check if the Ctrl key, Alt key, and middle mouse button were pressed if ( event.ctrlKey && event.altKey && (event.button === 0 || event.button === 1) ) { showDialog(event); return; }
Hope it helps
-
@MasterLeo29 said in Open in Dialog mod:
@oudstand While using it today, I noticed an odd bug. When using the Ctrl+Alt+Middle mouse click to open in dialog, it was opening two dialogs of the same url.
After a bit of debugging, I think I have a fix for you to test/include.
on your 'setUrlClickObserver', when adding the mousedown event listener, on the first if statement I added a 'return' so that it would not trigger the "show dialog" a second time
something like this snippet :
// Check if the Ctrl key, Alt key, and middle mouse button were pressed if ( event.ctrlKey && event.altKey && (event.button === 0 || event.button === 1) ) { showDialog(event); return; }
Hope it helps
Oh good idea. You probably click slower than I do
-
@oudstand
Nicely done! May I use this script to complement my Vivaldi Custom UI Mod? Of course with full credits. -
@srazzano4 Yes, feel free to use.
-
Thank you. Posted my Vivaldi Custom Mod on my Github page https://github.com/Razzano/Vivaldi_Custom with your script attached minus the search functions since it duplicates the Apps' Search With contextmenuitem.
-
@srazzano4 said in Open in Dialog mod:
minus the search functions since it duplicates the Apps' Search With contextmenuitem.
That's right a similar functionality already exists just without the dialog option
-
@oudstand
I tried installing the mod and there was an issue with my google searchYour file was not found
After some debugging it seems to be due to the url configuration for my google search, this is the url I use:
{google:baseURL}search?q=%s&{google:originalQueryForSuggestion}{google:prefetchSource}{google:sourceId}{google:contextualSearchVersion}ie={inputEncoding}
And to get the correct url I also found the function
vivaldi.searchEngines.getSearchRequest('16', 'test', console.log)
-
@tam710562 You're right this was failing. I've updated the code. Thanks for helping
-
Ok, got it.
-
@srazzano4 Please, post code in Code-Blocks! the </> button!
https://commonmark.org/help/tutorial/09-code.html -
@srazzano4 I think with the current version of the mod, the google search should work. Do you still have a problem?
-
OK, got it.
-
@srazzano4 I've updated the
dialogTabSearch
function. I've tested it with this URLhttps://www.google.de/search?q=%s
and the URL provided by @tam710562
{google:baseURL}search?q=%s&{google:originalQueryForSuggestion}{google:prefetchSource}{google:sourceId}{google:contextualSearchVersion}ie={inputEncoding}
-
any chance the url could be manipulated manually as well?
-
@xef you mean to insert an URL into the input on top of the dialog?
-
yes, being able to manipulate and navigate the address bar manually would be incredibly useful!
-
@xef Good idea, I'll take a look
-
@oudstand you've contributed to another mod i liked, UWP, that a lot of similar features in dialog mod would be pretty cool. thanks for taking a look into it and thanks for such a cool tool.
-
@xef I've added the feature:
- if you edit the URL of a dialog and hit
Enter
the dialog will open the URL - if it's not a URL the dialog will use the default search engine to search for the input
- if you edit the URL of a dialog and hit
-
Very amazing extension, let me experience the preview function of arc in vivaldi, but the preview window can not use the extension, it would be better if you could add extension and script support, you can add a switch in the code whether to turn on the extension