VivaldiHooks - more useful mods!

Pathduck

@den_po I've just started using a couple of these hooks, some of them are really useful and should be made the defaults in Vivaldi. Love the SD keyboard shortcuts

Just a couple of things:

If I remove the js files I don't need from the hooks folder will it be better for "performance" as it won't need to load and parse them on startup?
What is the "startup mode" for new hooks?
The qc-close-tab is nice, but would be even nicer if tabs could be closed with Delete as well. I just added a feature request to the Github

den_po

@Pathduck said in VivaldiHooks - more useful mods!:

If I remove the js files I don't need from the hooks folder will it be better for "performance" as it won't need to load and parse them on startup?

I've just checked, parsing of all default hooks takes 60 milliseconds at my PC.

What is the "startup mode" for new hooks?

I'm not sure I correctly understand your question. There is "Startup mode for new items" settings parameter (when jdhooks-startup-settings.js is installed of course), it works for hooks Vivaldi settings storage doesn't know about. You may disable newly appearing hooks by default.

The qc-close-tab is nice, but would be even nicer if tabs could be closed with Delete as well. I just added a feature request to the Github

Ok

Pathduck

@den_po said in VivaldiHooks - more useful mods!:

I'm not sure I correctly understand your question. There is "Startup mode for new items" settings parameter

I was just wondering what the checkbox does. Is it just for marking new hooks with the red "NEW" mark?

den_po

@Pathduck said in VivaldiHooks - more useful mods!:

I was just wondering what the checkbox does. Is it just for marking new hooks with the red "NEW" mark?

It's to make "new" hooks enabled. Or disabled if you wish.

den_po

New wiki page with mods descriptions https://github.com/justdanpo/VivaldiHooks/wiki/Hooks

Steffie

@den_po Nice!

I found this interesting:

disable-VB-25302.js
Disables annying feature "Populate Find in Page dialog with current page text selection" (VB-25302)

I actually love that feature of V; for me it is not annoying but very handy. It always interests me to learn the many different ways we each like to use our favourite browser.

Pathduck

@den_po I've noticed that VivaldiHooks causes issues with the Guest Profile. Specifically, the Go buttons show (twice), status bar at top, title bar is blue, maybe from one of the Theme colours (my Highlight is #006ed7).

I can't say I remember this from earlier versions. Maybe this started with one of the latest snapshots, not sure.

My impression was that the hooks would not apply to the Guest profile at all, since there also is no Settings UI to control it.

Screenshot:

alt text

Not a major thing for me, but it might need some investigation.

A Former User

@Pathduck ~~seems to be doable w/ vivaldi.runtimePrivate.isGuestSession(function callback)~~

Edit: why just not disable defaultLoad? (as noted some posts below)

Pathduck

@potmeklecbohdan I really don't understand what you mean by that mate

Are you saying this is expected and that the Hooks do still apply in the Guest Profile, even the ones I've disabled?

The only hooks I've enabled is:

disable-VB-25302.js
qc-close-tab.js
speeddial-shortcuts.js
speeddial-spacing.js
zoom-control-wheel.js

A Former User

@Pathduck No, I’m saying that guest win can be detected w/ that & so just one more condition in the main hooks file should be enough (if they are expected to be disabled) (please note that I still don’t understand the file & so this statement may not be correct).

Pathduck

@potmeklecbohdan OK fair enough, maybe we'll need to hear from @den_po about this one.

Are you able to reproduce the same issue opening a Guest Profile in the latest Snapshot?

I could try to (manually) install the hooks in the last Stable to see if it's snap-related.

A Former User

@Pathduck It’s just that the “startup mode” is on by default (why didn’t I get this idea 2 posts earlier?). (I always spend 32 clicks just disabling all of them )

Sorry, I have now all mods & hooks disabled coz I want to finally write a script for them, but assume that I can reproduce this.

If you want to change the behavior right now, see line 169.

Pathduck

Well, I just tested installing the hooks in the Stable standalone, and the same thing. So I guess this is not something new, I guess I've just not used Guest View a lot recently so I've not noticed it

I think the behaviour should be to not apply the hooks to a guest profile, as it is expected to be as default as possible, meant for just that, a "Guest" user borrowing the browser for a bit.

It should still apply to a Private Window though, as that's just a private version of the standard profile.

@potmeklecbohdan

If you want to change the behavior right now, see line 169.

I'm afraid my JS skills are not up to par here. Do you mean just remove the "defaultLoad: true," part?

EDIT, sorry I'm an idiot - you obviously just meant set it to "false". D'oh!
Yeah that works

valiowk

Could someone help confirm whether autocomplete-domain.js has the following problem: Suppose one has a bookmark whose title has at least two words, e.g. "Test words". If one types "Test" in the address bar, then "Test%20words" is suggested in the address bar (instead of "Test words"), and typing a space after "Test" causes the address bar to show "Test%20words" instead of "Test "? Thanks!

A Former User

@Pathduck said:

I'm afraid my JS skills are not up to par here. Do you mean just remove the "defaultLoad: true," part?

EDIT, sorry I'm an idiot - you obviously just meant set it to "false". D'oh!
Yeah that works

Sorry, I somehow expect everyone to be at least a bit programming-literate. Yes, all needed was to change it to false

Edit: as I’m thinking of it, this was more about knowing how it’s used… I knew it was suspicious that you wouldn’t understand it at all!

A Former User

@valiowk Yeah, exactly. I wanted to test it on Vivaldi Forum, typed Vivaldi & got Vivaldi%20UI%20Customisations%20%7C%20Vivaldi%20Forum (cursor at the end, no selection)

Steffie

@potmeklecbohdan said in VivaldiHooks - more useful mods!:

expect everyone to be at least a bit programming-literate

Gulp!

Sweat...

nomadic

@potmeklecbohdan said in VivaldiHooks - more useful mods!:

I somehow expect everyone to be at least a bit programming-literate

Even at an engineering school, programming talk makes people's eyes glaze over.

Being one of the few people with coding experience in an embedded control class is ~~not~~ fun.

den_po

@Pathduck said in VivaldiHooks - more useful mods!:

@den_po I've noticed that VivaldiHooks causes issues with the Guest Profile

That is an interesting one. Even the simplest solution doesn't look easy to implement at the first glance. Gotta think about it.

@valiowk said in VivaldiHooks - more useful mods!:

Could someone help confirm whether autocomplete-domain.js has the following problem:

I've pushed a workaround. Please check it.

Pathduck

@den_po Thanks for the reply.

I've temporarily fixed it by setting defaultLoad: false in in jdhooks.js (as discussed above) but will have to re-apply it for every update obviously. What does "defaultLoad" actually do?

Everything else seems to still work as expected, and hooks appear to not load in Guest. They still load in a Private window as expected.