3.3 RC1: favicons broke for file:// URLs, including in the panel

Pathduck

I just noticed this one when clicking through the panels, suddenly all favicons for local (file:// URL) panels started taking on the icon of the first panel.

I then noticed when trying to re-add the panel manually, that when opening the html file I use for it, the favicon is no longer showing, it only shows as a "broken image" file. In fact, it shows the favicon for less than a second, then reverts to a broken image.

The code in the html is this:
<link rel=icon href="../res/css.ico">

However when the favicon links to a web-hosted icon, they work.
<link rel="icon" href="https://blog.fluent-forever.com/wp-content/uploads/2019/04/cropped-fluent-forever-favicon-32x32.png"/>

Example, the "Multisearch" uses an externally located icon:

Then when I actually re-added the panel, all the icons seemed to revert back to normal. I assume this is because of some internal caching taking hold, possibly?

I have been able to repro this in a clean snapshot profile, but it behaves a bit differently so will need to do more diggin. The favicons show fine in 3.2 stable.

Just want to hear if someone else has encountered this yet, before I report it?
EDIT: Reported as VB-71326

Pathduck

This one's on a clean snapshot profile:

Last one is a regular web panel over https.
I think the "Loading..." might be a clue to what's going on?

But now for some reason the favicon in the regular profile show as they should
Curiouser and curiouser...

Pathduck

Update again: after a restart I got the same issue where the icons all got replaced by the icon of the first one I clicked.

I had the sense to look in the UI inspector and the code for the button image is this:

	<img src="chrome://favicon/about:blank#blocked" alt="">

Notice the about:blank#blocked for the img element. This fits the situation I also had at the outset, where when I tried to copy the panel address I just got that exact same address.

Pathduck

I reported this as VB-71326. Really don't want this to make its way into Stable. I suspect it's already been reported, @Gwen-Dragon could you check please?

Pathduck

Update: This is still in 3.5.2110.3.

Panel address is about:blank#blocked and the title stays as Loading...

This below is after adding all the local (file://) panels again and restarting Vivaldi. Note how the icon changes, in this case to the last added panel. The last icon below the local ones are on the net and the icon is fine.

alt text

I believe it's related to Vivaldi not loading favicons for file:// URLs.

Pathduck

@Gwen-Dragon OK, I will wait until the next snapshot. I'm just worried if Stable will come without it being fixed.

You use local file:// panels? Can you confirm the favicon show also in a regular page when the HTML files are opened? Most of my panels have <link rel=icon href="../res/css.ico"> but it's also the same with the ico file in the same folder.

Pathduck

@Gwen-Dragon Already have :smiling_face_with_open_mouth_closed_eyes:
(VB-71326) Web panel favicons broken for file:// URLs, link to about:blank

Pathduck

@Gwen-Dragon Thank you