How to contribute the source code ?

kumiponi

@WillyYu One way is to try to contribute to the Chromium project because Vivaldi is build on top of it. To suggest changes in the actual Vivaldi code, you would need to contact the development team, file a bug report, or post a feature request, as appropriate.

WillyYu

I have submitted the changes to Github.
https://github.com/WillyYu/vivaldi_1.7

If any problem or concern, please let me know.
Thanks

Tiamarth

According to a Vivaldi developer on Reddit, people have submitted changes to him, and he has added those changes. I would suggest, based on that information, that you contact Vivaldi staff and submit your changes to them.

WillyYu

@Tiamarth Got it. I will remove the change on the Github

Cqoicebordel

@WillyYu Leave them here for the time being. I'm filing a bug and pinging the devs that could merge your code right now.

EDIT : Created VB-26302

WillyYu

@Cqoicebordel Great!!!, Many thanks.

Cqoicebordel

@WillyYu No problem ! We want to have those enhancements too
I think you will be contacted directly if and when the devs take it on their laps. All we can do now is wait and see (and push for it a little )

Dantesoft

@WillyYu Is the patch relative to the published vivaldi-source_1.7.735 ?

If so, I think it would make sense for the Vivaldi devs to also publish the source snapshots on Github (for example), to help others branch/comment/review.

Arguably anyone can unpack the archives from vivaldi.com/source and do it by hand, but things would be simpler with an official repository.

WillyYu

@Dantesoft Yes, it is relative to 1.7.735.
Agree!! It is really helpful if having a official repository.

Cqoicebordel

@WillyYu One of the issues is that Jon (the big boss) is kind of afraid of going full open source because he had bad experiences with it, and that it would use a lot of ressources to check every patch submitted, and accept them or not. Right now, almost every time the devs create a new feature, a bunch of regressions happens. If that was to be the reality with external patches as well, it would be unbearable for the little structure that Vivaldi is.

That's why nothing to accept patches, or just to help external devs, is created right now. They don't have the ressources to manage it, so they don't encourage it.

That said, the current proposed patch WILL be examined and (I hope) integrated. But don't expect them going full open source any time soon (even if we push for it).

den_po

@WillyYu said in How to contribute the source code ?:

I have submitted the changes to Github.
https://github.com/WillyYu/vivaldi_1.7

If any problem or concern, please let me know.
Thanks

If you don't like DIFF you may put unpatched files there too. It would help a lot.

WillyYu

@Cqoicebordel Understand.The startup has limited resource but lots thing need to do.
That's all right if those patches couldn't be integrated. I believe your devs have their concern.
I just wanna to help because those patches are from my Vivaldi experience. I think that Vivaldi could be better.

Ayespy

@WillyYu - of course Vivaldi can be better. It's quite immature still. But it could be the best browser in the world and still could be better - and the developers welcome all the help they can get to make it better. It goes without saying that since it is closed source (though built on open-source technologies), they will determine and direct the flow of development, set their own priorities and use their best wisdom in view of the totality of feedback, concerning sequence of actions. But most of us here really believe in the promise represented by the browser and do what we can to help them continually make it better.

other

@WillyYu I had a look at your changes, and the change in |BrowserPlugin::updateGeometry| will help performance. The changes to ReactList is no longer necessary since it has been replaced in a recent rewrite.

Great to have you on-board, and thanks for the improvements!

WillyYu

@other Great!! I am glad that patch can help.
I will keep trying to find out somewhere that can be improved in the future.
Or if there are some issue that I can help, you can contact me.
Thanks