Closing saved session multiplies pinned tabs in regular session
-
@Pesala And, it seems in Win10, Chrome, if not pinned to taskbar (I don't know about all chromium-based browsers) leaves the original window open while closing all others when you select "Close all Windows." Other apps don't do this.
-
@Pesala said in Closing saved session multiplies pinned tabs in regular session:
@Ayespy @astro46 said right-click, not hover. If I right-click I don't see the window preview thumbnails, and the only option is Close all windows.
again, odd. I don't see "close all windows" , only "close window"
However, since there is a neat work-around for the case where the user wants to close a window with pinned tabs including the pinned tabs, then there is no issue. The default behaviour is as expected, and the devs were right to close this bug as invalid.
Unbelievable that this bug was closed as invalid. Why would they think that moving saved session pinned tabs to an unsaved session is expected behavior? Why then, not move all the tabs from saved session to the unsaved session? Why have duplicates of tabs as expected behavior? Why leave the upper right close button on a saved session if using it is going to create behavior that no one would want? If is a 'work around', this is an admission of a bug. The reasoning is outrageous. It will be kinder to assume they made a mistake or didn't understand the issue.
-
@astro46 said in Closing saved session multiplies pinned tabs in regular session:
Why then, not move all the tabs from saved session to the unsaved session?
As I said, once a saved session has been opened it is no longer a saved session. If you add or delete tabs, then restart Vivaldi and reopen the save session the added and deleted tabs are not updated in the saved session.
If Don't close pinned tabs is enabled, and another window is open, the pinned tabs will
notbe moved to it instead of being closed. If only one window is open, the pinned tabs will still be present on restarting Vivaldi.If I have two or more windows open, then I see Close all windows. If I have only one open, then I see Close window.
-
@Pesala said in Closing saved session multiplies pinned tabs in regular session:
@astro46 said in Closing saved session multiplies pinned tabs in regular session:
Why then, not move all the tabs from saved session to the unsaved session?
As I said, once a saved session has been opened it is no longer a saved session. If you add or delete tabs, then restart Vivaldi and reopen the save session the added and deleted tabs are no updated in the saved session.
If Don't close pinned tabs is enabled, and another window is open, the pinned tabs will not be moved to it instead of being closed. If only one window is open, the pinned tabs will still be present on restarting Vivaldi.
hmm. 'don't close pinned tabs' is checked. pinned tabs are moving from the closed 'session' window to the still open original, not session, windo, immediately after upon closing. . No restarting vivaldi needed.
If I have two or more windows open, then I see Close all windows. If I have only one open, then I see Close window.
with 2 vivaldi windows open:
-
@woefdram said in Closing saved session multiplies pinned tabs in regular session:
Given that the purpose of a pinned tab is that you can't (accidentally) close it, it makes sense that when you have several windows open and you close a window with a pinned tab, the tab is reopened in another window.
That's not the purpose of pinned tabs. The central purpose of pinned tabs is to place them in a permanent location, namely at the beginning of the list of tabs. This way you can always easily find that tab. If it's not pinned the creation and deletion of other tabs can move it up & down (left & right depending on how you view tabs). Pin the tab and it will always be at the beginning of the list (among other pinned tabs if unmet they exist). You "pin" the tab in place, it can't move (without user intervention). There is an option to add the protection against being closed to pinned tabs.
@woefdram said in Closing saved session multiplies pinned tabs in regular session:
TL;DR: I think it should be customizable if you want this to happen or not.
It is, in the tabs settings there is an option to protect pinned tabs from being closed. Turn it on and pinned tabs cannot be closed, even if you close the window currently holding them. Actions not explicitly effecting pinned tabs cannot close them if they are protected against closure. Makes total sense. If you close the containing window, the pinned tabs having been protected against being closed are moved to another window. Closing the only open window is actually exiting the program, it is not ending the session as that session can be restored when the program next launches if you desire.
-
@woefdram said in Closing saved session multiplies pinned tabs in regular session:
TL;DR: I think it should be customizable if you want this to happen or not.
It is, in the tabs settings there is an option to protect pinned tabs from being closed. Turn it on and pinned tabs cannot be closed, even if you close the window currently holding them. Actions not explicitly effecting pinned tabs cannot close them if they are protected against closure. Makes total sense. If you close the containing window, the pinned tabs having been protected against being closed are moved to another window. Closing the only open window is actually exiting the program, it is not ending the session as that session can be restored when the program next launches if you desire."
That makes is sound like the current pinned tabs/saved session implementation is just fine. (Of course this doesn't explain the different behavior depending on how the window is closed.) On a more fundamental level I don't understand the continued desire to rationalize what is clearly bad implementation. Moving pinned tabs from one window to another is bad implementation, regardless of the rationalization.
I don't use 'sessions' any more because it is a half baked 'feature'. Not just the buggy way it deals with pinned tabs, but the inability to update sessions without going through some klugey save, rename, delete the old session sort of routine. A well designed feature would have the session not dump stuff into other windows if it isn't closed in a particular, undisclosed manner, and provide a simple option to 'update' the session using the same name.
"Sessions" acts like a feature that seemed like a good idea at the beginning, but the developers lost interest before it was fully developed. It wouldn't be terribly complicated to fix it, but the interest clearly isn't there.
-
@astro46 You're entitled to your opinion, but others clearly do not see a fault with the implementation.
A Sessions Panel is one of the most popular feature requests, but the Vivaldi Team is small.
-
@astro46 said in Closing saved session multiplies pinned tabs in regular session:
Moving pinned tabs from one window to another is bad implementation, regardless of the rationalization.
This makes it sound like your opinion is fact. Regardless of how fundamental this approach is to your design sensibilities, that doesn't mean everyone agrees with you, or that either opinion is the "good" or correct way.
I don't use 'sessions' any more because it is a half baked 'feature'.
That's unfortunate, you could probably stop them from being moved to the other window by unchecking that box -- I'm not sure, I haven't tried.
Personally, I always found sessions to be nothing more than just a quick way to save my state before closing everything down for a reboot, or to free up resources before starting a resource intensive task. That was until I discovered the Advanced Panels Mod (with Sessions Panel).
Combined with the Autosave Sessions Mod, the Sessions Panel has made sessions something I make effective & regular use of now. It's a great way to save a bunch of tabs related to some project that I am putting on hold while dealing with other things. I typically move all the tabs to a new window, then save that as a session before closing that window. This means I don't have to save all those tabs in a temporary bookmarks folder and clutter my library with a bunch of bookmarks I have no intention of keeping longterm, many of which I may not have even looked at.
The Autosave Sessions Mod protects my state from accidental closure of a lot of tabs or some hard failure. The Advanced Web Panels Mod provides me with a nice workflow for saving, accessing and managing my sessions. Those two mods really round out the sessions functionality, making it a powerful feature that has greatly improved my workflows.
I don't find something this minor as being so catastrophic that I'm unable to even use sessions, but if you've found alternative workflows that are better for you that's great. That's what is awesome about Vivaldi, enabling people to achieve things in many different essays.
-
I agree it's a minor thing, but even if the purpose of a pinned tab is merely to fix its position, it doesn't make sense to move it to another window when you have it set to "don't close". And I also agree that's just my (and apparently others) opinion, that's why it would be nice to fix it or better yet make it optional when a dev has the time to get around to it.
Also, there was talk about a there being a workaround for this, but I can't relate what was said about that to how this works on Linux. I use Shift-Ctrl-W to close a window without closing the browser.
-
@BoneTone Thanks for info about the Autosave Sessions Mod. Hadn't heard of it, don't understnd exactly what it does, but it seems like something I would like to look into further.
-
Out of curiousity, I changed the pinned tabs setting from 'don't close pinned tabs", to 'minimize instead of close'. Same behavior. If I close a session window with the upper right close X, all the pinned tabs get saved to the still open original windows, as more pinned tabs. so changing the pinned tabs setting doesn't change the errant behavior.
Which brings us to another bit of bizarre behavior. I just discovered the tab right click menu gives the option to save tabs to session. (I should say sometimes it gives the option. Other times right clicking does nothing. No right click menu. Have to close and reopen vivaldi to get right click to work again. And, it isn't a problem with my mouse. The right click continues to work in other places, but not on the tabs.) So, I have a Saved Session composed of only a few saved regular, unpinned tabs. I open the Saved Session and find all tabs are opened as pinned tabs. Not as the unpinned tabs that they started out as. And, of course, if I don't close the window in the secret way, they will all get added to my original, not saved session window, as more pinned tabs.
Vivaldi really has an unhealthy obsession with pinned tabs.
-
@astro46 said in Closing saved session multiplies pinned tabs in regular session:
@BoneTone Thanks for info about the Autosave Sessions Mod. Hadn't heard of it, don't understnd exactly what it does, but it seems like something I would like to look into further.
Sorry, I normally include links to any mods I mention. Here is the AutoSave Sessions mod. It will automatically save your session based on a configurable time interval, and only keep the most recent autosaved sessions (how many to keep is also configurable). So I have it set to autosave every 20 minutes and keep 10. If something happens, like accidentally closing a bunch of windows or a catastrophic failure, I have my state no older than 20 minutes saved in the sessions, and I've got 10 copies of my state over the past 3 hours that I can go back and restore if I realize I made a mistake and lost something.
Here's the Advanced Panels mod, which includes the Sessions Panel as an example of how to create advanced panels, but it's the only advanced panel I have. That sessions panel alone is worth installing, and as I mentioned is what made sessions usable to me. The UI/UX fits into my workflow perfectly. The dev was very clever and built the mod in an abstract way allowing people to extend it with their own ideas for advanced panels.
If you don't know how to install mods, read Modding Vivaldi which is the first thread pinned in the Modifcations category, it explains everything.
@astro46 said in Closing saved session multiplies pinned tabs in regular session:
ut of curiousity, I changed the pinned tabs setting from 'don't close pinned tabs", to 'minimize instead of close'. Same behavior.
A while back, I had changed it to "Close as other tabs" and noticed the same thing. That, to me is the bug. As would be different behavior depending upon how you invoke a command. These are the kinds of things that occur when you have a small team and completely strip off the Chromium UI and implement and entirely new interface using different underlying technology. It is why Vivaldi has all the flexibility and configurability that other browsers are unable to offer; it also means that when you start getting into these less commonly used features and digging into the corner cases, you're absolutely going to find bugs. Dig into the less popular features of any piece of software and poke around and you'll start finding quirks, but Vivaldi is young and "resource challenged". That said, all things considered, it's still the best browser for the way I like to work. The problems it presents me are less painful than the problems other browsers present me. I am not the median (typical) or mean (average) user though, which is why I'm here I guess as Vivaldi isn't targeting the typical or average.
-
@astro46 said in Closing saved session multiplies pinned tabs in regular session:
Which brings us to another bit of bizarre behavior. I just discovered the tab right click menu gives the option to save tabs to session. (I should say sometimes it gives the option. Other times right clicking does nothing. No right click menu. Have to close and reopen vivaldi to get right click to work again.
I think all that fiddling you did in your profile has corrupted it, and is causing you some issues that others aren't seeing.
On the tab bar I get:
On the window panel I get:
@astro46 said in [Closing saved session multiplies pinned tabs in regular session]
If I have two or more windows open, then I see Close all windows. If I have only one open, then I see Close window.
with 2 vivaldi windows open:
The reason you're getting different behavior than others is because you don't group your tabs (BTW, which version of Windows are you, I missed it if you mentioned it.) As a comparison, I have my windows grouped, and if I click on the Vivaldi icon on the taskbar I get close all windows. If I right click on one of the window thumbnails that appear when hovering over the Vivaldi icon I get the same context menu as if I right-clicked on the titlebar of that window.
-
perhaps i will rebuild the profile. but not tonight.
I get the same as you on the tab bar and the window panel. And when right clicking on taskbar tabs.
No I don't group the tabs.
I am using win10 1909 64 bit.
-
I've been seeing this also and it was as confusing as hell. I find it hard to believe that this behaviour is by design. A session which includes some pinned tabs and which will include those pinned tabs when you reopen it should not dump the pinned tabs somewhere else when you close the session window. Almost makes me want to just use a speed dial right click than the session feature, which does seem to have not kept up with e.g. Edge collections. Sorry if I'm missing something in this rather long thread but this seems like a bug, and I'll file a bug report.
-
@aach1 good luck with the bug report. Perhaps the changes will be made to make the saved sessions be a well designed feature. maybe, perhaps. i filed bug report long ago.
-
@aach1 said in Closing saved session multiplies pinned tabs in regular session:
when you close the session window.
There is no "session window", all windows are part of the same "current session".
-
@BoneTone I think that it doesn't help to contest comments about problems users are having because of technicalities/terminology. The issues are real, and are best used to improve functionality and good user experiences. eg: if the vivaldi commend is 'open session in new window' , then the user has every right to expect that the new window is a separate "session". Not that most people think much about the definition of a 'session' . Most users are not web designers and not familiar with terminology.
-
@astro46 said in Closing saved session multiplies pinned tabs in regular session:
if the vivaldi commend is 'open session in new window' , then the user has every right to expect that the new window is a separate "session". ... Most users are not web designers and not familiar with terminology.
But the user would be wrong, leading to the misunderstandings we're discussing about what sessions are and how they work. I'm not being pedantic about terminology, it's an important distinction that users need to understand in order to have proper expectations for how the product works, as I and others have been trying to explain since March. I should have perhaps written more about it in my previous reply; but I lacked the time then, so I waited until I did have the time to write and apologize if I came off as curt.
Understanding what a session is in Chromium-based browsers isn't overly complicated, and definitely doesn't require any knowledge of programming. Some people have already explained the basics a few times in this thread, but as confusion persists I decided to extract the general parts of this and put it into its own thread, which is here.
With respect to terminology however, perhaps that action could be better named. At first, I wasn't really sure what that could be, after writing that guide however, it seems that perhaps "Restore session in new window" might be better language for that menu item. Or maybe that guide on how sessions work will give someone an idea for better wording if they want to submit a request for that.
A few core points to understand include:
- All browser windows and the tabs they contain are part of the same session -- different windows are not separate sessions, regardless of how they were created.
- Saved Sessions only exist on-disk, and currently cannot be updated. They provide users with the ability to restore a historical snapshot of the browser's prior state.
- When a saved session is restored its contents become a part of the single current session, and the restored tab(s) as well as any additional windows do not retain any association with the saved session.
There is a bug (or bugs) here, with pinned tabs getting moved to another window when the user tries to close the window containing a pinned tab. This isn't, however, in any way related to sessions, saved or otherwise. Part of the reason for your old bug being closed as invalid might have been due to a misunderstanding about this.
Going forward, I see two issues, though the first might be by design.
First, there is the fact that pinned tabs will move to another window when the containing window is closed regardless of the how the close option is set for pinned tabs. Personally, I would think that it gets moved if pinned tabs are set to not be closed, and simply close with the window otherwise.
Second, there is the issue that this move happens before the positive confirmation to close the window, and therefore can occur even if the user doesn't actually close the window. If the user has the close window confirmation enabled, the tab gets moved when the close window action is invoked (e.g. via the X button), but the user can cancel that close operation still yet the tab has already been moved to another window. This is clearly a bug.
I'm fairly certain no one has reported the second issue. If someone has, let me know, otherwise I'll report it tomorrow.
-
@BoneTone said in Closing saved session multiplies pinned tabs in regular session:
But the user would be wrong, leading to the misunderstandings we're discussing about what sessions are and how they work. I'm not being pedantic about terminology, it's an important distinction that users need to understand
....Saved Sessions only exist on-disk, and currently cannot be updated. They provide users with the ability to restore a historical snapshot of the browser's prior state.
Quite a long reply this time. I think that this is a conflict between terminology with its application, and functionality. What users have been explaining is that the functionality is less than optimal. In fact, to a certain extant it is bad. Focusing on whether sessions operate correctly from a terminology viewpoint misses the point. and for users that point is all that matters. If vivaldi is expecting people who aren't browser designers to be using the browser (and I believe the do) then user expectations, usability, elegance, are all that matter. Technically correct use of terminology is irrelevant. The productive response is to change how sessions function or perhaps simply remove the sessions function if it can't be made to operate in a way that users expect. The goal is to make users happy.
Closing a "saved session window" from the taskbar dropdown causes the window to close without moving pinned tabs to the already open window (as explained in early posts). Only closing the window with the upper right X produces multiple pinned tabs. This indicates that the problem can be solved with attention to programming and is clearly either a bug or a very bizarre design choice..
The saved session is only bringing back a Selected part of the browser's prior state: whatever tabs were saved for 'saved session'. An argument can be made that opening the saved session in a new window shouldn't open the pinned tabs at all, since that weren't saved as the 'saved session'. In addition, the inability to more elegantly update the saved session (either by option to 'update session' or offer the existing session name as 'new' saved session name, overwriting the previous, or, some other way, is another indication that this was a good idea that didn't get the development that it deserved before it was released.