Clicking on address bar search field magnifying glass not dropping down list of engines, if I add 2 or more manual engines via Settings



  • @iAN-CooG said in VivaldiHooks - more useful mods!:

    if both alt+4 and alt+6 are used in keyboard shortcuts, clicling or cursordown on the searchfield I get:

    Uncaught TypeError: Cannot read property 'length' of undefined
    at Object.componentWillMount (bundle.js:18)
    at f.performInitialMount (vendor-bundle.js:48)
    at f.mountComponent (vendor-bundle.js:48)
    at Object.mountComponent (vendor-bundle.js:12)
    at d.mountChildren (vendor-bundle.js:49)
    at d._createInitialChildren (vendor-bundle.js:48)
    at d.mountComponent (vendor-bundle.js:48)
    at Object.mountComponent (vendor-bundle.js:12)
    at d.mountChildren (vendor-bundle.js:49)
    at d._createInitialChildren (vendor-bundle.js:48)

    EDIT:
    It's not an error in the altered vendor-bundle.js, I've disabled jdhooks in browser.html and restored vendor-bundle.js from the 1.7.715.3\Installer\vivaldi.7z, same error. I can safely assume it's a Vivaldi error and I can bugreport it.

    @iAN-CooG said in VivaldiHooks - more useful mods!:

    Just an update, I've added another report for it, seems more related to the number of search engines defined. I had 20, after deleting last 2, engines list works again. The keys are irrelevant, it's a side effect of another overflow.

    (Breaking this out into a seperate topic, as it isn't related to VivaldiHooks, which I don't have installed currently.)

    I didn't need to set any special shortcuts for the address bar's search field's magnifying glass button to stop working.

    I was able to trigger the bug just by adding two extra (non-default) search engines, as long as they were manually added via Settings (not by right clicking on pages and selecting "Add as Search Engine").

    I've filed an extra bug report for this finding.

    Similar to you, if I inspect Vivaldi, I see the following in the console when I click the magnifying glass:

    bundle.js:19 Uncaught TypeError: Cannot read property 'length' of undefined
        at t.value (bundle.js:19)
        at f.performInitialMount (vendor-bundle.js:50)
        at f.mountComponent (vendor-bundle.js:50)
        at Object.mountComponent (vendor-bundle.js:12)
        at d.mountChildren (vendor-bundle.js:51)
        at d._createInitialChildren (vendor-bundle.js:50)
        at d.mountComponent (vendor-bundle.js:50)
        at Object.mountComponent (vendor-bundle.js:12)
        at d.mountChildren (vendor-bundle.js:51)
        at d._createInitialChildren (vendor-bundle.js:50)
    

    (Vivaldi 1.7.735.11 - I've encountered the problem on both Windows and OS X -- haven't checked it on Linux yet)



  • I noticed the number of engines to trigger this error varies, I can have 18 at home and only 15 at work pc, but then also varies depending on which of the list is selected as default. On work's pc it seemed that I could add 17 before triggering it, but i had google as 1st in the list. After setting the 7th engine, in my case youtube, the list doesn't appear anymore, and the console shows the e undefined. Removing 2 more engines then all the remaining ones can be selected without triggering the error. There must be some unchecked array size overflow, hence the undefined behaviour.


  • Moderator

    Did you send a bugreport to Vivaldi? If not please do.


    How to do a bugreport for Vivaldi:
    Please describe the issue as precise as you can and report the bug at https://vivaldi.com/bugreport/.
    You will get a bug confirmation mail and in a reply to this mail you can add more information and files as attachments for the testers and bug tracking team.
    Thanks in advance.




  • @Gwen-Dragon

    Me? Yes, as mentioned above, I did so before posting about it. I thought to mention it here as well because it was already being discussed, and it seemed to me I had noticed another wrinkle (that it doesn't even require a long list, just a couple of manually added entries).

    iAN CooG also previously filed a report, as mentioned the latter post I quoted (at least, I interpret "I've added another report for it" to mean submitted to the official report form).



  • @Gwen-Dragon Yes I did
    (VB-24740) Alt+4 and Alt+6 in keyboard shortcut cause a bug in Search field
    then explained better in
    (VB-24824) Too many Search Engines set cause a bug in Search field



  • Seems fixed in https://vivaldi.com/blog/snapshots/vivaldi-1-7rc-1-vivaldi-browser-snapshot-1-7-735-36/
    [Regression] Cannot change search engine in search field with Japanese UI (VB-25427)
    this fix also includes implicitly a fix for my report
    (VB-24824) Too many Search Engines set cause a bug in Search field
    Now I have 25 engines defined and the bug doesn't show up when selecting them in the search field. Good work.

    Still happens that the other dropdown list of keyword only reacts to shift-down, and not on clicking the right down triangle icon.
    BUT if I open the settings with ctrl-p, the triangle icon reacts again on mouse click. I'll open another report just in case.



  • reported as:
    (VB-25547) In Search field, keyword dropdown list doesn't react to mouse click


Log in to reply
 

Looks like your connection to Vivaldi Forum was lost, please wait while we try to reconnect.