Solved Signature position for reply and forward
-
@gmg Thanks.
-
@honzamf @burnout426 @Klookschieter
Fixed and pushed. Should be out in next snapshot.
Look for
VB-69065 [Mail] Signature should be applied above the quoted history in a reply composer
-
Thank you very much
-
-
@gmg Testing in 5.2.2623.3. Awesome!
I see a few issues.
- There's no signature inserted when composing a new message if "Place signature at the top" is set.
In this case, the normal signature should be inserted at the end of the message.
- When "Place signature at the bottom" is set, and you reply, there are too many blank lines above the quoted text.
As in, it's currently body="\n\n\n\nOn Friday..." instead of body="\n\nOn Friday...".
- When "Place signature at the top" is set, and you reply, there are 2 blank lines between the signature and quoted text instead of just 1.
As in, it's currently body="\n\nMichael\n\n\nOn Friday..." instead of body="\n\nMichael\n\nOn Friday..."
MODEDIT: Issues reported as
VB-87865: [Mail] Extra linebreaks before and after signature
VB-87877: [Mail] Missing signature when composing new message and “Place signature at the top” enabled
-
Ok, I addressed those issues (and an issue with empty body when opening draft that my changes had caused).
Look for these in next Snapshot release
VB-87865: [Mail] Extra linebreaks before and after signature
VB-87877: [Mail] Missing signature when composing new message and “Place signature at the top” enabled
VB-87798: [Regression] Mail : Body missing when opening draft
-
-
-
There is one mistake:
When you set insert signature at the top and want to create a new email there is no signature.
When we set the signature at the bottom in the new email, the signature appears correctly -
@tomasz-kozlowski
That's already addressed there in the changes mentioned above. Just hasn't been released. Just look for VB-87877 in next snapshot -
@gmg Awesome!
-
@gmg In 5.2.2623.12, with "Place signature at bottom", there's no blank line between the signature separator ("-- ") and the quoted text.
-
@burnout426
You're presumably talking about for plain text replies.
I can fix it if you make a bug -
@gmg Yes. VB-87970
-
Hm, is it just me or, if the signature is empty, Vivaldi still includes
--
in a new draft whenever I start composing an e-mail? Has it been reported?
-
@felagund I think this is known, I've seen someone mention this a while ago so I (who is also mildly annoyed by this) didn't report it again. Not sure about the bug number though.
-
Fix for the missing line is in. Look for this in next snapshot
VB-87970: Missing blank line between signature and quoted text when replying to plain text message with "Place signature at bottom" set
-
@gmg said in Signature position for reply and forward:
Fix for the missing line is in. Look for this in next snapshot
VB-87970: Missing blank line between signature and quoted text when replying to plain text message with "Place signature at bottom" set
@gmg That issue with "--" with empty signatures is known or should we fill a bug about it?
-
It's filed. I'll fix it
-
Issue with empty signatures adding "-- " is now fixed. Look for this commit in next snapshot
VB-87217: Don't add signature delimiter if there's no signature
-
That was quick, thank you!
-
@gmg Looks good in 5.3.2669.3 64-bit on Windows 11 Version 21H2 (Build 22000.652).